Skip to content

Conversation

@mndza
Copy link
Contributor

@mndza mndza commented Jan 7, 2026

Also fixes #1629

@mossmann
Copy link
Member

mossmann commented Jan 7, 2026

This does not fix #1629 for me. I can get the spectrum to invert by repeatedly adjusting the sample rate. It sometimes gets into a state where crossing a decimation threshold (usually at 2.5 Msps) reliably flips the spectrum for a while.

This may have been random, but it seemed like it was easier to reproduce the problem after changing the starting sample rate from 2.5 Msps to 20 Msps in the flowgraph.

@mndza mndza force-pushed the generic-sgpio-intf branch from 9f3f799 to a9ec1fd Compare January 9, 2026 09:09
@mndza mndza requested a review from mossmann January 9, 2026 09:17
@mndza mndza force-pushed the generic-sgpio-intf branch from a9ec1fd to c8b0910 Compare January 9, 2026 10:28
@mndza mndza force-pushed the generic-sgpio-intf branch 2 times, most recently from 36ce57f to 3824424 Compare January 9, 2026 12:18
mndza added 2 commits January 9, 2026 16:19
Simplified the filter architecture by using an adder tree for obtaining
the final sum of the subfilters (vs systolic array). Previously, no
backpressure (always_ready=True) worked fine but otherwise we lost
samples.
Prevent loosing track of the IQ time-multiplexing state within the FIR
filter.
@mndza mndza force-pushed the generic-sgpio-intf branch from 3824424 to 4218aee Compare January 9, 2026 15:23
@mndza mndza force-pushed the generic-sgpio-intf branch from 4218aee to 7631832 Compare January 9, 2026 15:25
@mndza mndza changed the title gateware: generic SGPIOInterface, simpler capture management, fix SB_MAC16 resamplers gateware: generic SGPIOInterface, simpler capture mgmt, fix resampler bugs Jan 9, 2026
Copy link
Member

@mossmann mossmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you!

@mossmann mossmann merged commit 663c993 into greatscottgadgets:main Jan 12, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Praline: spectrum inverts randomly when changing sample rate

2 participants